Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Port Name overrides on web-api-service #326

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ibrahimparvez2
Copy link

@ibrahimparvez2 ibrahimparvez2 commented Feb 4, 2023

When deploying this chart with Istio ingress due to istio's convention which requires port names to be prefixed http- this subsequently results in needing to patch web-api-svc manifest post deployment.

Changes proposed in this pull request

This allows users to override the default names provided which eases the issues when using istio service mesh

Contributor Checklist

  • Variables are documented in the README.md
  • Which branch are you merging into?
    • master is for changes related to the current release of the concourse/concourse:latest image and should be good to publish immediately
    • dev is for changes related to the next release of Concourse (aka unpublished code on master in concourse/concourse)

Reviewer Checklist

This section is intended for the core maintainers only, to track review progress. Please do not
fill out this section.

  • Code reviewed
  • Topgun tests run
  • Back-port if needed
  • Is the correct branch targeted? (master or dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant