highlight that CONCOURSE_TSA_AUTHORIZED_KEYS is a public key #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generate 3 keys and those envs should contain private keys: - CONCOURSE_TSA_HOST_KEY - CONCOURSE_TSA_AUTHORIZED_KEYS - CONCOURSE_TSA_WORKER_PRIVATE_KEY end up reading golang code, running GO SSH with similar configuration and ended with understanding that ssh keys does not match. Ideally, I would suggest to rename those envs but I believe it will might be a breaking changes for old users. So at least, I hope, this will help to improve documentation keywords for google: - concourse ci PTY allocation request failed on channel 0 - concourse ci shell request failed on channel 0 - concourse ci tsa.connection.handshake-failed Signed-off-by: Vlad <[email protected]>
vladyslav2
force-pushed
the
feat/improve-web-envs/0000
branch
from
cf8f2e3
to
4f9a75d
Compare
vladyslav2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I read installation guide for a couple times I was sure I need to generate 3 keys and those envs should contain private keys (hey they all without .pub so it must be private keys)
ended up reading golang code, creating small script with GO SSH and a similar configuration and ended with understanding that ssh keys does not match.
Ideally, I would suggest to rename those envs but I believe it will might be a breaking changes for old users. So at least, I hope, this will help to improve documentation
keywords for google: