Initial Drone support #1069
Merged
Initial Drone support #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
reviewed
May 6, 2019
isuruf
reviewed
May 6, 2019
isuruf
reviewed
May 6, 2019
isuruf
reviewed
May 6, 2019
scopatz
reviewed
May 7, 2019
|
Thanks for putting this in @jmreicha! |
|
See #1070. You can rebase on top of that PR or merge that PR here. |
|
Can you merge this branch with master? |
isuruf
reviewed
May 8, 2019
isuruf
reviewed
May 8, 2019
This was referenced May 9, 2019
|
I think changes still need to be made to If somebody else wants to take it over that would be great, otherwise progress will be much slower. |
isuruf
reviewed
May 23, 2019
| template_files = platform_templates.get(platform, []) | ||
|
|
||
| # Explicitly add in a newline character to ensure that jinja templating doesn't do something stupid | ||
| build_setup = "run_conda_forge_build_setup\n" |
There was a problem hiding this comment.
Can you use _get_build_setup_line here?
|
Looks good to me. We can merge this now and work on CI registration later. |
|
Thanks so much for this! |
Closed
I've gone ahead and raised issue ( #1079 ) to track this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
newsentryResolves conda-forge/conda-forge.github.io#269.
This PR aims to add native aarch64/armv8 builds to Conda forge. Currently the Arm builds are emulated using QEMU and leverage Azure pipelines. The main issues with this approach is that Azure limits the number of CPUs for builds to 2, so large builds are slow and relying on QEMU for Arm emulation can potentially have side effects.
Adding Drone support alleviates these issues by offering native aarch64/armv8 build support as well as offering many more CPUs for builds, which should significantly speed up builds and reduce build times and avoid potential bugs/side effects.