Manual harfbuzz 10 migration #74

Tobias-Fischer · 2025-01-07T06:49:02Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

…onda-forge-pinning 2024.12.21.10.18.30

Tobias-Fischer · 2025-01-07T06:49:12Z

conda-forge-admin · 2025-01-07T06:50:25Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12649661804. Examine the logs at this URL for more detail.}

…onda-forge-pinning 2025.01.06.23.00.11

Tobias-Fischer · 2025-01-07T07:28:25Z

@traversaro - we need this for the ros-noetic rebuild. Do you have any idea about the Windows failure?

(%BUILD_PREFIX%) %SRC_DIR%>ninja -v -C builddir -j 2 
ninja: fatal: ReadFile: The handle is invalid.
ninja: Entering directory `builddir'

[1/1204] "D:\bld\glib-split_1729191053212\_build_env\python.exe" "D:/bld/gtk3-split_1736233127491/_h_env/Library/bin/glib-genmarshal" "--quiet" "--prefix" "_gdk_marshal" "--valist-marshallers" "--output" "gdk/gdkmarshalers.h" "--header" "../gdk/gdkmarshalers.list" "--pragma-once"

FAILED: gdk/gdkmarshalers.h 
"D:\bld\glib-split_1729191053212\_build_env\python.exe" "D:/bld/gtk3-split_1736233127491/_h_env/Library/bin/glib-genmarshal" "--quiet" "--prefix" "_gdk_marshal" "--valist-marshallers" "--output" "gdk/gdkmarshalers.h" "--header" "../gdk/gdkmarshalers.list" "--pragma-once"
CreateProcess failed: The system cannot find the file specified.

traversaro · 2025-01-07T07:56:39Z

My guess is that it may be related to:

2025-01-07T07:04:29.7261295Z Program D:/bld/gtk3-split_1736233127491/_h_env/Library/bin/glib-compile-schemas found: YES (D:/bld/gtk3-split_1736233127491/_h_env/Library/bin\glib-compile-schemas.EXE)
2025-01-07T07:04:29.7264583Z WARNING: Target "gsettings-compile-demos\gtk-demo" has a path separator in its name.
2025-01-07T07:04:29.7265825Z This is not supported, it can cause unexpected failures and will become
2025-01-07T07:04:29.7267138Z a hard error in the future.
2025-01-07T07:04:30.8227002Z C++ compiler for the host machine: cl.exe (msvc 19.29.30157 "Microsoft (R) C/C++ Optimizing Compiler Version 19.29.30157 for x64")
2025-01-07T07:04:30.8229441Z C++ linker for the host machine: link link 14.29.30157.0

However, I will try to build this locally to understand more (not before CET evening of the 7th, as I am going through some backlog).

conda-forge-admin · 2025-01-07T10:26:23Z

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12649693750. Examine the logs at this URL for more detail.}

conda-forge-admin · 2025-01-07T10:31:07Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12818349886. Examine the logs at this URL for more detail.}

ryanvolz · 2025-01-07T16:26:39Z

I think glib is a good lead. This is the error in the latest build:

2025-01-07T11:22:16.1497278Z (%BUILD_PREFIX%) %SRC_DIR%>ninja -v -C builddir -j 2 
2025-01-07T11:22:16.2089832Z ninja: fatal: ReadFile: The handle is invalid.
2025-01-07T11:22:16.2090431Z ninja: Entering directory `builddir'
2025-01-07T11:22:16.2105592Z 
2025-01-07T11:22:16.2106671Z [1/1204] "D:\bld\glib-split_1729191053212\_build_env\python.exe" "D:/bld/gtk3-split_1736248580980/_h_env/Library/bin/glib-genmarshal" "--quiet" "--prefix" "_gdk_marshal" "--valist-marshallers" "--output" "gdk/gdkmarshalers.h" "--header" "../gdk/gdkmarshalers.list" "--pragma-once"
2025-01-07T11:22:16.2120454Z 
2025-01-07T11:22:16.2121086Z FAILED: gdk/gdkmarshalers.h 
2025-01-07T11:22:16.2130546Z "D:\bld\glib-split_1729191053212\_build_env\python.exe" "D:/bld/gtk3-split_1736248580980/_h_env/Library/bin/glib-genmarshal" "--quiet" "--prefix" "_gdk_marshal" "--valist-marshallers" "--output" "gdk/gdkmarshalers.h" "--header" "../gdk/gdkmarshalers.list" "--pragma-once"
2025-01-07T11:22:16.2137280Z CreateProcess failed: The system cannot find the file specified.

where the file that it cannot find is D:\bld\glib-split_1729191053212\_build_env\python.exe, which doesn't exist because it's looking for a path from the glib build! I haven't looked at what has changed about the glib build yet but figured this was a helpful observation to put out there.

ryanvolz · 2025-01-07T16:50:24Z

I think glib is a good lead. This is the error in the latest build:

2025-01-07T11:22:16.1497278Z (%BUILD_PREFIX%) %SRC_DIR%>ninja -v -C builddir -j 2 
2025-01-07T11:22:16.2089832Z ninja: fatal: ReadFile: The handle is invalid.
2025-01-07T11:22:16.2090431Z ninja: Entering directory `builddir'
2025-01-07T11:22:16.2105592Z 
2025-01-07T11:22:16.2106671Z [1/1204] "D:\bld\glib-split_1729191053212\_build_env\python.exe" "D:/bld/gtk3-split_1736248580980/_h_env/Library/bin/glib-genmarshal" "--quiet" "--prefix" "_gdk_marshal" "--valist-marshallers" "--output" "gdk/gdkmarshalers.h" "--header" "../gdk/gdkmarshalers.list" "--pragma-once"
2025-01-07T11:22:16.2120454Z 
2025-01-07T11:22:16.2121086Z FAILED: gdk/gdkmarshalers.h 
2025-01-07T11:22:16.2130546Z "D:\bld\glib-split_1729191053212\_build_env\python.exe" "D:/bld/gtk3-split_1736248580980/_h_env/Library/bin/glib-genmarshal" "--quiet" "--prefix" "_gdk_marshal" "--valist-marshallers" "--output" "gdk/gdkmarshalers.h" "--header" "../gdk/gdkmarshalers.list" "--pragma-once"
2025-01-07T11:22:16.2137280Z CreateProcess failed: The system cannot find the file specified.

where the file that it cannot find is D:\bld\glib-split_1729191053212\_build_env\python.exe, which doesn't exist because it's looking for a path from the glib build! I haven't looked at what has changed about the glib build yet but figured this was a helpful observation to put out there.

This has been observed and fixed a little while ago but for Unix builds: conda-forge/glib-feedstock#192. I created an issue at glib saying that this is still a problem on Windows.

traversaro · 2025-01-07T23:01:00Z

Fix attempted in conda-forge/glib-feedstock#199.

hmaarrfk · 2025-01-16T17:56:58Z

@conda-forge-admin please rerender

…onda-forge-pinning 2025.01.16.17.10.46

hmaarrfk · 2025-01-16T18:49:13Z

Nice. Fix windows and ~~Linux~~ osx breaks

hmaarrfk · 2025-01-16T19:21:46Z

I think we hit: conda/conda-build#5594

@conda-forge-admin please rerender

conda-forge-admin · 2025-01-16T19:24:01Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12816093156. Examine the logs at this URL for more detail.}

hmaarrfk · 2025-01-16T21:29:33Z

@conda-forge-admin please rerender

conda-forge-admin · 2025-01-16T21:31:57Z

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

_{This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12817940916. Examine the logs at this URL for more detail.}

Tobias-Fischer · 2025-01-17T01:09:54Z

Looks like this is good to go? Thanks @hmaarrfk @traversaro @ryanvolz!

hmaarrfk · 2025-01-17T01:28:09Z

Yeah. I guess I forced a fix so merge away?

Tobias-Fischer · 2025-01-17T10:25:41Z

Yes I think it's fine @hmaarrfk as it will disappear with the next rerender which will happen for the next PR anyhow (and by then hopefully the problem will have disappeared)

hmaarrfk · 2025-01-17T11:53:55Z

Well it is in the hands of the maintainers now

regro-cf-autotick-bot and others added 3 commits December 22, 2024 15:42

Rebuild for harfbuzz 10

b9fffe6

MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.1, and c…

2f25fbb

…onda-forge-pinning 2024.12.21.10.18.30

Fix cairo not found

d847020

Tobias-Fischer requested review from ryanvolz, stuarteberg and tschoonj as code owners January 7, 2025 06:49

MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.1, and c…

0a111f4

…onda-forge-pinning 2025.01.06.23.00.11

Tobias-Fischer mentioned this pull request Jan 7, 2025

January 2025 rebuild using rattler-build RoboStack/ros-noetic#501

Merged

Add missing liblzma-devel dep

abd2a55

Tobias-Fischer added 3 commits January 7, 2025 20:05

Disable demos on Windows

5d0d4fd

Avoid finding system cmake

7f97e04

Deps also in subpackage

1a304e9

Fix spacing

726ca90

Tobias-Fischer added 3 commits January 7, 2025 21:00

Re-enable demos

486380e

Try old glib 2.80 which was used in last builds

fbda7be

Unpin, incompatible

b22a98e

ryanvolz mentioned this pull request Jan 7, 2025

Incorrect Python shebang in Windows package for glib-genmarshal, glib-mkenums, gtester-report conda-forge/glib-feedstock#198

Closed

1 task

MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.2, and c…

7300f4d

…onda-forge-pinning 2025.01.16.17.10.46

Manually limit py-lief<0.15.0a0 on OSX

e3b0dc8

ryanvolz merged commit 6f42bd8 into conda-forge:main Jan 17, 2025
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual harfbuzz 10 migration #74

Manual harfbuzz 10 migration #74

Tobias-Fischer commented Jan 7, 2025

Tobias-Fischer commented Jan 7, 2025

conda-forge-admin commented Jan 7, 2025 •

edited

Loading

Tobias-Fischer commented Jan 7, 2025

traversaro commented Jan 7, 2025

conda-forge-admin commented Jan 7, 2025

conda-forge-admin commented Jan 7, 2025 •

edited

Loading

ryanvolz commented Jan 7, 2025

ryanvolz commented Jan 7, 2025

traversaro commented Jan 7, 2025

hmaarrfk commented Jan 16, 2025

hmaarrfk commented Jan 16, 2025 •

edited

Loading

hmaarrfk commented Jan 16, 2025

conda-forge-admin commented Jan 16, 2025

hmaarrfk commented Jan 16, 2025

conda-forge-admin commented Jan 16, 2025

Tobias-Fischer commented Jan 17, 2025

hmaarrfk commented Jan 17, 2025

Tobias-Fischer commented Jan 17, 2025

hmaarrfk commented Jan 17, 2025

Manual harfbuzz 10 migration #74

Manual harfbuzz 10 migration #74

Conversation

Tobias-Fischer commented Jan 7, 2025

Tobias-Fischer commented Jan 7, 2025

conda-forge-admin commented Jan 7, 2025 • edited Loading

Tobias-Fischer commented Jan 7, 2025

traversaro commented Jan 7, 2025

conda-forge-admin commented Jan 7, 2025

conda-forge-admin commented Jan 7, 2025 • edited Loading

ryanvolz commented Jan 7, 2025

ryanvolz commented Jan 7, 2025

traversaro commented Jan 7, 2025

hmaarrfk commented Jan 16, 2025

hmaarrfk commented Jan 16, 2025 • edited Loading

hmaarrfk commented Jan 16, 2025

conda-forge-admin commented Jan 16, 2025

hmaarrfk commented Jan 16, 2025

conda-forge-admin commented Jan 16, 2025

Tobias-Fischer commented Jan 17, 2025

hmaarrfk commented Jan 17, 2025

Tobias-Fischer commented Jan 17, 2025

hmaarrfk commented Jan 17, 2025

conda-forge-admin commented Jan 7, 2025 •

edited

Loading

conda-forge-admin commented Jan 7, 2025 •

edited

Loading

hmaarrfk commented Jan 16, 2025 •

edited

Loading