-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable llvm wasm target #83
Enable llvm wasm target #83
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
b1b3b7f
to
3ac8bea
Compare
.ci_support/linux_64_.yaml
Outdated
c_stdlib_version: | ||
- '2.12' | ||
- '2.27' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You cannot do this manually (will disappear on a recipe rerender), and we don't have 2.27, because there are only RHEL-based increments (2.12, 2.17, 2.28).
You should be able to set the following in recipe/conda_build_config.yaml
:
c_stdlib_version: # [linux]
- 2.28 # [linux]
but note that support for that is not 100% complete yet (though this part should work).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I will try it. Also, do you know if we need to explicitly install c_stdlib like:
diff --git a/recipe/meta.yaml b/recipe/meta.yaml
index 0af9edb..635f7c4 100644
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -18,6 +18,7 @@ requirements:
build:
- {{ compiler('c') }}
- {{ compiler('cxx') }}
+ - {{ stdlib("c") }}
- cmake =3.21.1
- make # [unix]
- xeus =3.0.5 # [build_platform != target_platform]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/home/conda/wasi-sdk-21.0/bin/clang: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by /home/conda/wasi-sdk-21.0/bin/clang)
Looks like using 2.28
doesn't seem to help.
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.05.27.20.59.24
So I don't know this recipe, but from what I can tell, the stuff in
Again, without knowing the details of this recipe, it's very likely that the wasi-sdk should be built in conda-forge itself for use in this recipe. |
Ah, nevermind what I said, what we need is to change the image to This isn't in widespread use yet, but we can try with a newer docker image. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2024.05.27.20.59.24
@@ -1,5 +1,5 @@ | ||
set(SRC | ||
- ../../../src/libasr/runtime/lfortran_intrinsics.c | ||
+ ${CMAKE_CURRENT_SOURCE_DIR}/../../../src/libasr/runtime/lfortran_intrinsics.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)