OpenCL and GPU builds #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isuruf
requested review from
aldanor,
jameslamb,
synapticarbors and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
xhochy
reviewed
Jun 25, 2024
recipe/meta.yaml
Outdated
| number: 1 | ||
| script: {{ PYTHON }} -m pip install . | ||
| number: {{ build_num }} | ||
| string: {{ impl }}_py{{ PY_VER }}h{{ PKG_HASH }}_{{ build_num }} |
There was a problem hiding this comment.
Shouldn't this also work? conda-build normally evaluates it after reading number
Suggested change
| string: {{ impl }}_py{{ PY_VER }}h{{ PKG_HASH }}_{{ build_num }} | |
| string: {{ impl }}_py{{ PY_VER }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }} |
isuruf
commented
Jun 25, 2024
recipe/meta.yaml
Outdated
| string: {{ impl }}_py{{ PY_VER }}h{{ PKG_HASH }}_{{ PKG_BUILDNUM }} | ||
| script: | ||
| - set "CMAKE_ARGS=%CMAKE_ARGS% -DUSE_CUDA=1" # [impl == "cuda" and win] | ||
| - set "CMAKE_ARGS=%CMAKE_ARGS% -DUSE_GPU=1" # [impl == "cpu" and win] |
There was a problem hiding this comment.
Is this okay? I've changed the default CPU builds to include OpenCL as well since it's a lightweight dependency.
jameslamb
approved these changes
Jun 28, 2024
There was a problem hiding this comment.
This looks great, thank you for all the hard work!
Just commenting to confirm the things I noticed:
- it's totally fine to skip the CUDA build on Windows... LightGBM does that too: [python-package] CUDA version not truly installing microsoft/LightGBM#6417 (comment)
- the CMake patch makes sense to me... I understand why you wouldn't want to statically link Boost for a conda package
|
Thanks for the review. Merge? |
xhochy
approved these changes
Jun 29, 2024
|
thanks @xhochy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)