Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Yazi #28210

Merged
merged 11 commits into from
Nov 22, 2024
Merged

Adding Yazi #28210

merged 11 commits into from
Nov 22, 2024

Conversation

hoxbro
Copy link
Contributor

@hoxbro hoxbro commented Nov 14, 2024

Resolves #28109

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/yazi/meta.yaml) and found some lint.

Here's what I've got...

For recipes/yazi/meta.yaml:

  • ❌ Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [13]
  • ❌ This recipe is using a compiler, which now requires adding a build dependence on {{ stdlib("c") }} as well. Note that this rule applies to each output of the recipe using a compiler. For further details, please see META: {{ stdlib("c") }} migration conda-forge.github.io#2102.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/yazi/meta.yaml) and found it was in an excellent condition.

@hoxbro hoxbro closed this Nov 14, 2024
@hoxbro hoxbro reopened this Nov 14, 2024
@hoxbro hoxbro marked this pull request as ready for review November 14, 2024 19:00
@hoxbro
Copy link
Contributor Author

hoxbro commented Nov 15, 2024

@conda-forge/help-rust, ready for review. Thank you!

This is my first time creating a rust conda package, so I'm unsure about the static libraries tasks.

recipes/yazi/build.sh Show resolved Hide resolved
recipes/yazi/build.sh Outdated Show resolved Hide resolved
recipes/yazi/build.sh Outdated Show resolved Hide resolved
recipes/yazi/bld.bat Outdated Show resolved Hide resolved
recipes/yazi/bld.bat Outdated Show resolved Hide resolved
recipes/yazi/bld.bat Outdated Show resolved Hide resolved
@hoxbro
Copy link
Contributor Author

hoxbro commented Nov 22, 2024

@conda-forge/help-rust, ready for review. Thank you!

@xhochy xhochy merged commit 5190f48 into conda-forge:main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Package request: yazi
3 participants