Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding iterativefiltering package #28246

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

EmanuelePapini
Copy link

@EmanuelePapini EmanuelePapini commented Nov 17, 2024

added iterativefiltering to recipes

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/iterativefiltering/meta.yaml) and found some lint.

Here's what I've got...

For recipes/iterativefiltering/meta.yaml:

  • ❌ The home item is expected in the about section.

For recipes/iterativefiltering/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/iterativefiltering/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/iterativefiltering/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12026939292. Examine the logs at this URL for more detail.

@EmanuelePapini
Copy link
Author

@conda-forge/help-python
Conda check fails in building for mac OS X. I have no idea of why that happens

added iterativefiltering to recipes
added maintainer github username
added home information in about in meta.yaml
@EmanuelePapini
Copy link
Author

@conda-forge/help-python my recipe for iterativefiltering is ready for review

sha256: 02a89ea3a05aaddf3497a9928da515e4e5a42ba4b1e4868dbc80f03362733deb

build:
noarch: python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the convention for noarch: python described in:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the documentation again with regard to using {{ python_min }} in the host, run and test sections.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have modified the .yaml file according to the documentation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have another look at the docs I linked. Under host and under the requires section of test it should be - python {{ python_min }}

Copy link
Author

@EmanuelePapini EmanuelePapini Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@synapticarbors Ok, but I need to specify (for compatibility reasons with numba) that the version must be earlier than 3.13. I thought that the way I did it was correct. How can I do that in the .yaml file?
Also, I would like to note that in the documentation you pointed me at, the use of python_min is not mandatory (since it uses the noun "should" instead of "must") or am I mistaken?
Also, is there a python_max variable that can be used?

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants