-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding iterativefiltering package #28246
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/iterativefiltering/meta.yaml:
For recipes/iterativefiltering/meta.yaml:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/iterativefiltering/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12026939292. Examine the logs at this URL for more detail. |
@conda-forge/help-python |
added iterativefiltering to recipes
added maintainer github username
added home information in about in meta.yaml
@conda-forge/help-python my recipe for iterativefiltering is ready for review |
sha256: 02a89ea3a05aaddf3497a9928da515e4e5a42ba4b1e4868dbc80f03362733deb | ||
|
||
build: | ||
noarch: python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the convention for noarch: python
described in:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the documentation again with regard to using {{ python_min }}
in the host
, run
and test
sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have modified the .yaml file according to the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have another look at the docs I linked. Under host
and under the requires
section of test
it should be - python {{ python_min }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@synapticarbors Ok, but I need to specify (for compatibility reasons with numba) that the version must be earlier than 3.13. I thought that the way I did it was correct. How can I do that in the .yaml file?
Also, I would like to note that in the documentation you pointed me at, the use of python_min is not mandatory (since it uses the noun "should" instead of "must") or am I mistaken?
Also, is there a python_max variable that can be used?
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
added iterativefiltering to recipes
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).