Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for ada-url #28258

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add recipe for ada-url #28258

wants to merge 2 commits into from

Conversation

rHermes
Copy link

@rHermes rHermes commented Nov 18, 2024

Hey, this is my first submission, so please bear with me 😅

I think I've followed all outlined requirements, the only one I'm insecure about is the "static" requirement. ada normally doesn't ship a dynamic library, it's only exporting headers and lib/libada.a. I don't know if this disqualifies it or not, but I needed this for my own purposes, and so I thought I would upstream this :)

I have not tested the windows build, but I hope the CI will.

Please let me know if you have any comments!

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/ada-url/recipe.yaml) and found it was in an excellent condition.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 18, 2024

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11895533712.

@rHermes
Copy link
Author

rHermes commented Nov 18, 2024

Hey! This package is ready for review @conda-forge/help-c-cpp, but I'm not sure why the linter is failing? I've followed the instructions given in: https://prefix.dev/blog/building_cpu_optimized_packages but I'm getting a linter error now.

@rHermes
Copy link
Author

rHermes commented Nov 18, 2024

Ok, so I looked more into it and it seems that while the conda-smithy lint_recipe.py https://github.com/conda-forge/conda-smithy/blob/main/conda_smithy/lint_recipe.py#L253, does load the variant, while the github workflow script does not take into account this. Since it doesn't read this in, it doesn't have the context it needs when it's expanding the script.

I'm guessing this has no easy fix?

@rHermes
Copy link
Author

rHermes commented Nov 18, 2024

So I managed to get the syntax past the lint checker, thought obviously it's not ideal.

@wolfv
Copy link
Member

wolfv commented Nov 24, 2024

Hi @rHermes looks good to me! I think there is a slight bug in the linter code that I can take a look at on Monday and then we can hopefully merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants