Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clmm package to conda #28338

Merged
merged 11 commits into from
Nov 25, 2024
Merged

Conversation

eduardojsbarroso
Copy link
Contributor

@eduardojsbarroso eduardojsbarroso commented Nov 24, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@eduardojsbarroso
Copy link
Contributor Author

@conda-forge/help-python , ready for review!

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 24, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clmm/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/clmm/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/11998514085. Examine the logs at this URL for more detail.

@synapticarbors
Copy link
Member

The import test is failing with ImportError: No modeling backend available.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1089710&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff&l=980

I'm not familiar with the package, so I'm not sure what type of configuration might be missing.

recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
@eduardojsbarroso
Copy link
Contributor Author

The import test is failing with ImportError: No modeling backend available.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1089710&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff&l=980

I'm not familiar with the package, so I'm not sure what type of configuration might be missing.

Hello synapticarbors,
So the code relies in one out of three backends. The simplest one to install would be Pyccl. Although this package can be installed simply by running

conda install pyccl

the pip version depends on CMake and I found some problems making this package a dependency, so I removed it. However the enviroment must have this installed so import clmm does not break.

2 questions:

  1. Can I add this to be a dependency here, even though is not a dependency on the Pypi repository? I tried to do so, but the tests seem to continue failing
  2. If yes, how should I proceed?

Thank you

@synapticarbors
Copy link
Member

There are some misconfigured dependencies that are causing pip check issues:
conda-forge/tables-io-feedstock#31
conda-forge/qp-feedstock#27
conda-forge/pyccl-feedstock#44
conda-forge/pyccl-feedstock#43 (comment)

@beckermr
Copy link
Member

Just turn pip check off. It doesn't matter and is wrong in many cases.

recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
recipes/clmm/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-admin

This comment was marked as resolved.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/clmm/meta.yaml) and found it was in an excellent condition.

@beckermr
Copy link
Member

I agree to maintain here.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@synapticarbors synapticarbors merged commit 1d1c513 into conda-forge:main Nov 25, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants