Code changes in decider service

conductor-oss · Nov 19, 2024 · 5b018ae · 5b018ae
1 parent da987b6
commit 5b018ae
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...k/conductor-client/src/main/java/com/netflix/conductor/common/metadata/tasks/TaskDef.java b/...k/conductor-client/src/main/java/com/netflix/conductor/common/metadata/tasks/TaskDef.java
@@ -427,7 +427,7 @@ public long getTotalTimeoutSeconds() {
     public void setTotalTimeoutSeconds(long totalTimeoutSeconds) {
         this.totalTimeoutSeconds = totalTimeoutSeconds;
     }
-    
+
     public String toString() {
         return name;
     }

diff --git a/core/src/main/java/com/netflix/conductor/core/execution/DeciderService.java b/core/src/main/java/com/netflix/conductor/core/execution/DeciderService.java
@@ -629,6 +629,7 @@ Optional<TaskModel> retry(
         rescheduled.setStartTime(0);
         rescheduled.setEndTime(0);
         rescheduled.setWorkerId(null);
+        rescheduled.setFirstStartTime(task.getFirstStartTime());
 
         if (StringUtils.isNotBlank(task.getExternalInputPayloadStoragePath())) {
             rescheduled.setExternalInputPayloadStoragePath(
@@ -710,14 +711,22 @@ void checkTaskTimeout(TaskDef taskDef, TaskModel task) {
         }
 
         long timeout = 1000L * taskDef.getTimeoutSeconds();
+        long totalTaskTimeout = 1000L * taskDef.getTotalTimeoutSeconds();
         long now = System.currentTimeMillis();
         long elapsedTime =
                 now - (task.getStartTime() + ((long) task.getStartDelayInSeconds() * 1000L));
 
+        long elapsedTimeFromFirstTaskExecution =
+                now - (task.getFirstStartTime() + ((long) task.getStartDelayInSeconds() * 1000L));
+
         if (elapsedTime < timeout) {
             return;
         }
 
+        if(elapsedTimeFromFirstTaskExecution < totalTaskTimeout) {
+            return;
+        }
+
         String reason =
                 String.format(
                         "Task timed out after %d seconds. Timeout configured as %d seconds. "