Merge pull request #4 from math29/bugfix/setVariable-error-message

bugfix: wrong unit used in SetVariable error message
conductor-oss · Dec 16, 2023 · c1bf109 · c1bf109
2 parents 3c15237 + 4fe1aae
commit c1bf109
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/core/src/main/java/com/netflix/conductor/core/execution/tasks/SetVariable.java b/core/src/main/java/com/netflix/conductor/core/execution/tasks/SetVariable.java
@@ -66,7 +66,7 @@ private boolean validateVariablesSize(
             if (payloadSize > maxThreshold * 1024) {
                 String errorMsg =
                         String.format(
-                                "The variables payload size: %d of workflow: %s is greater than the permissible limit: %d bytes",
+                                "The variables payload size: %d of workflow: %s is greater than the permissible limit: %d kilobytes",
                                 payloadSize, workflowId, maxThreshold);
                 LOGGER.error(errorMsg);
                 task.setReasonForIncompletion(errorMsg);

diff --git a/...harness/src/test/groovy/com/netflix/conductor/test/integration/SetVariableTaskSpec.groovy b/...harness/src/test/groovy/com/netflix/conductor/test/integration/SetVariableTaskSpec.groovy
@@ -62,7 +62,7 @@ class SetVariableTaskSpec extends AbstractSpecification {
         def EXTRA_HASHMAP_SIZE = 17
         def expectedErrorMessage =
                 String.format(
-                        "The variables payload size: %d of workflow: %s is greater than the permissible limit: %d bytes",
+                        "The variables payload size: %d of workflow: %s is greater than the permissible limit: %d kilobytes",
                         EXTRA_HASHMAP_SIZE + maxThreshold * 1024 + 1, workflowInstanceId, maxThreshold)
 
         then: "verify that the task is completed and variables were set"