code changes for terminateWorkflows

conductor-oss · Nov 18, 2024 · d0967c1 · d0967c1
1 parent b29c947
commit d0967c1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/client/src/main/java/com/netflix/conductor/client/http/WorkflowClient.java b/client/src/main/java/com/netflix/conductor/client/http/WorkflowClient.java
@@ -256,7 +256,7 @@ public void deleteWorkflow(String workflowId, boolean archiveWorkflow) {
      * @param reason the reason to be logged and displayed
      * @return the {@link BulkResponse} contains bulkErrorResults and bulkSuccessfulResults
      */
-    public BulkResponse<String> terminateWorkflows(List<String> workflowIds, String reason) {
+    public BulkResponse terminateWorkflows(List<String> workflowIds, String reason) {
         Validate.isTrue(!workflowIds.isEmpty(), "workflow id cannot be blank");
         return postForEntity(
                 "workflow/bulk/terminate",

diff --git a/common/src/main/java/com/netflix/conductor/common/model/BulkResponse.java b/common/src/main/java/com/netflix/conductor/common/model/BulkResponse.java
@@ -21,6 +21,8 @@
 /**
  * Response object to return a list of succeeded entities and a map of failed ones, including error
  * message, for the bulk request.
+ *
+ * @param <T> the type of entities included in the successful results
  */
 public class BulkResponse<T> {
 

diff --git a/...-sdk/conductor-client/src/main/java/com/netflix/conductor/client/http/WorkflowClient.java b/...-sdk/conductor-client/src/main/java/com/netflix/conductor/client/http/WorkflowClient.java
@@ -255,7 +255,7 @@ public void deleteWorkflow(String workflowId, boolean archiveWorkflow) {
      * @param reason the reason to be logged and displayed
      * @return the {@link BulkResponse} contains bulkErrorResults and bulkSuccessfulResults
      */
-    public BulkResponse<String> terminateWorkflows(List<String> workflowIds, String reason) {
+    public BulkResponse terminateWorkflows(List<String> workflowIds, String reason) {
         Validate.isTrue(!workflowIds.isEmpty(), "workflow id cannot be blank");
 
         ConductorClientRequest request = ConductorClientRequest.builder()