-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add WHILE Task #14
base: main
Are you sure you want to change the base?
Conversation
Does this support to do the decision from a SIMPLE task's output ? or a subworkflow's output ? |
Yes, similar to the |
0aa5695
to
04654a6
Compare
HI @Young-Zen thanks for the PR. This is a good to have, however, if we are adding a new task I think there is an opportunity here to address some of the shortcomings of do_while including support for nested loops, and a bit of usability with terminating conditions etc. |
Hi, thank you for your feedback on the PR. I agree that there are opportunities to address the shortcomings of do_while, including support for nested loops and improving the usability of terminating conditions. I believe we can consider these enhancements in a subsequent PR to ensure a more comprehensive improvement. For the current PR, I will focus on adding the WHILE task as requested. If you have any further suggestions or considerations, please feel free to share them. Thank you! |
I'm curious - what are the differences between this task and the existing Edit: Nevermind, found it in the PR: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for sharing
Pull Request type
./gradlew generateLock saveLock
to refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApply
to fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Netflix/conductor#3747
Alternatives considered
Describe alternative implementation you have considered