Feature # 220 - Make redis key space domain customizable #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes redis key space domain customizable, there by allowing multi-tenant software to namespace | isolate their data in the same redis db. This primarily applies to the hash bucket keys. In com.netflix.conductor.redis.dao.BaseDynoDAO instead of the domain being a member variable, access from the property instance on demand. A derived bean instance of ConductorProperties (already a member of BaseDynoDAO) will be able to access the customized domain seamlessly.
v1r3n
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes redis key space domain customizable, there by allowing multi-tenant software to namespace | isolate their data in the same redis db. This primarily applies to the hash bucket keys.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
In com.netflix.conductor.redis.dao.BaseDynoDAO instead of the domain being a member variable, access from the property instance on demand.
Describe the new behavior from this PR, and why it's needed
Issue #
A derived bean instance of ConductorProperties (already a member of BaseDynoDAO) will be able to access the customized domain seamlessly.
Alternatives considered
Considered stack, domain is better as implied is a more meaningful attribute to depend on