Adding an extension to archive workflows in S3 bucket #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
In this PR, we've added a new option to start saving workflows to S3. To use this feature, set the
workflowArchivalTypeproperty toS3. You can also set a time-to-live (TTL) for how long workflows should be kept before archiving. Additionally, there's a new property calledworkflowArchiveUnsuccessfulOnlythat allows you to archive only the workflows that failed.Describe the new behavior from this PR, and why it's needed
This PR lets you save workflows to S3. To do this, set the
workflowArchivalTypeproperty and provide the bucket name and region also if needed. You can also choose to only archive failed workflows to save on storage costs by setting theworkflowArchiveUnsuccessfulOnlyproperty. Path on S3 bucket will be workflow_name/workflow_id.Alternatives considered
Describe alternative implementation you have considered