Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added (incubating) Java Client v3 project to conductor-clients dir #255

Merged
merged 7 commits into from
Sep 17, 2024

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Sep 11, 2024

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Added (incubating) Java Client v3 project to conductor-clients dir.

Changes in this PR

This PR adds the Conductor Java Client v3 project to conductor-clients.

This client now utilizes OkHttp3 4.12.0 (replacing Jersey), adds support for events, filters, and listeners to enhance extensibility, and has undergone dependency optimization to reduce classpath pollution, prevent conflicts, and minimize its footprint.

Support will be added through different modules.

We've introduced 2 modules which add support to Orkes Conductor specific features.

TODO

@jmigueprieto jmigueprieto requested a review from v1r3n September 11, 2024 15:51
@jmigueprieto jmigueprieto self-assigned this Sep 11, 2024
}
};
final SSLContext sslContext = SSLContext.getInstance("SSL");
sslContext.init(null, trustAllCerts, new SecureRandom());

Check failure

Code scanning / CodeQL

`TrustManager` that accepts all certificates High

This uses
TrustManager
, which is defined in
ConductorClient$
and trusts any certificate.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is optional. Just for development purposes.

There's a warn in the logs

Unsafe client - Disabling SSL certificate validation is dangerous and should only be used in development environments

@Haven-King
Copy link

While the existing Java SDK will not be deprecated, I would still probably add a line to the README of that module along the lines of "see incubating SDK" with a link to this new one.

- Added module with minimal Prometheus Collector
@jmigueprieto
Copy link
Contributor Author

While the existing Java SDK will not be deprecated, I would still probably add a line to the README of that module along the lines of "see incubating SDK" with a link to this new one.

@Haven-King Makes sense. We'll do that (in a different PR)

@jmigueprieto jmigueprieto merged commit affd819 into main Sep 17, 2024
8 checks passed
@jmigueprieto jmigueprieto deleted the client_sdks_java_v3 branch September 17, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants