Fix flaky tests in HierarchicalForkJoinSubworkflowRerunSpec & HierarchicalForkJoinSubworkflowRestartSpec
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on which integration_task_2 will be polled and completed first.
c4lm
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
The assertions made by these tests were wrong causing them to be flaky. Example:
It failed in these recent runs:
And then passed:
The root cause of the issue is that a workflow forks a subworkflow task and an
integration_task_2task. The subworkflow also has anintegration_task_2task so there are NO guarantees on whichintegration_task_2will be polled and completed first.