Update Java Client v4 documentation #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmigueprieto
commented
Sep 18, 2024
| @@ -6,6 +6,10 @@ on: | |||
| types: | |||
| - completed | |||
|
|
|||
| # allow this workflow to update the status of the PR that triggered it | |||
| permissions: | |||
| statuses: write | |||
There was a problem hiding this comment.
Apart from the documentation I'm making this change to fix a 403 response when trying to update the PR status https://github.com/conductor-oss/conductor/actions/runs/10930113251/job/30342332639#step:7:29
jmigueprieto
requested review from
c4lm,
codehackerr,
Haven-King,
manan164 and
v1r3n
jmigueprieto
force-pushed
the
doc/update-java-client-v4-documentation
branch
from
338b6bd to
5a6f03e
Compare
c4lm
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Java Client v4 Integration Testsworkflow.Notes
This PR was also meant to check if the changes in #260 are working as expected. The integration tests are running but because of permissions they cannot update the PR status.