[Java Client v4] External storage support + Event refactoring #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmigueprieto
force-pushed
the
fix/client-v4-external-storage-support
branch
from
2d91152 to
bfa68e8
Compare
jmigueprieto
commented
Oct 2, 2024
| @@ -370,42 +372,6 @@ private <T, R> R retryOperation(Function<T, R> operation, int count, T input, St | |||
| throw new RuntimeException("Exhausted retries performing " + opName); | |||
| } | |||
|
|
|||
| private void publish(TaskRunnerEvent event) { | |||
There was a problem hiding this comment.
Logic Moved to EventDispatcher
jmigueprieto
commented
Oct 2, 2024
| * A default implementation of {@link ConductorClientConfiguration} where external payload barriers | ||
| * is disabled. SEE: SEE: <a href="https://conductor-oss.github.io/conductor/documentation/advanced/externalpayloadstorage.html">External Payload Storage</a> | ||
| */ | ||
| public class DefaultConductorClientConfiguration implements ConductorClientConfiguration { |
There was a problem hiding this comment.
This and the upload/download logic were taken from Client V3 (current OSS client)
jmigueprieto
requested review from
c4lm,
v1r3n,
Haven-King,
manan164 and
ystxn
ystxn
approved these changes
Oct 3, 2024
|
Events from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
TaskClient.evaluateAndUploadLargePayloadandWorkflowClient.checkAndUploadToExternalStorage2.1 Moved Events out of automator package to
com.netflix.conductor.client.events.2.2 Extracted logic from
TaskRunnertoEventDispatcher- Events are not only published byTaskRunner.2.3
TaskClientandWorkflowClientpublish events related to external storage payload and workflow start.TODO
TaskClientandWorkflowClientin PrometheusMetricsCollector.