Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java Client v4] ConductorClient refactoring + Orkes client module cleanup #276

Merged
merged 2 commits into from
Oct 7, 2024
Merged

[Java Client v4] ConductorClient refactoring + Orkes client module cleanup #276

merged 2 commits into from
Oct 7, 2024

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Oct 4, 2024 •
edited
Loading

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

  • Changes in ConductorClient Builder to allow it to be extended.
  • Changes and cleanup in orkes-client module.
    • ApiClient won't be marked as deprecated.
    • ApiClient has a builder its own builder, with it's own properties. E.g.: credentials
import io.orkes.conductor.client.ApiClient;

ApiClient.builder()
   .basePath(basePath)
   .credentials(keyId, keySecret)
   .build()

@jmigueprieto
- orkes-client: ApiClient will not be deprecated.
3a93794 
- orkes-client: Added documentation to OrkesWorkflowClient.
- orkes-client: Removed ApiException (ConductorClientException should be used instead)
@jmigueprieto jmigueprieto changed the title Fix/orkes client fixes refactoring [Java Client v4] ConductorClient refactoring + Orkes client module cleanup Oct 4, 2024
@jmigueprieto jmigueprieto self-assigned this Oct 4, 2024
@jmigueprieto jmigueprieto force-pushed the fix/orkes-client-fixes-refactoring branch from 8465e6f to b7c95c4 Compare October 4, 2024 17:19
jmigueprieto
jmigueprieto commented Oct 4, 2024
View reviewed changes
.../java/conductor-java-sdk/orkes-client/src/main/java/io/orkes/conductor/client/ApiClient.java

public static class ApiClientBuilder extends Builder<ApiClientBuilder> {

public ApiClientBuilder credentials(String key, String secret) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added credentials to this builder

@jmigueprieto jmigueprieto marked this pull request as ready for review October 4, 2024 17:31
@jmigueprieto jmigueprieto merged commit 0366a58 into main Oct 7, 2024
6 checks passed
@jmigueprieto jmigueprieto deleted the fix/orkes-client-fixes-refactoring branch October 7, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c4lm c4lm c4lm approved these changes

@ystxn ystxn ystxn approved these changes

@v1r3n v1r3n Awaiting requested review from v1r3n

@Haven-King Haven-King Awaiting requested review from Haven-King

@manan164 manan164 Awaiting requested review from manan164

Assignees

@jmigueprieto jmigueprieto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmigueprieto @ystxn @c4lm