[Java client v4] Misc fixes #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of project.ext.has('artifactId')
…n mistake when getting these values from env variables for example.
jmigueprieto
commented
Oct 9, 2024
| @@ -1,16 +1,16 @@ | |||
| plugins { | |||
| id 'java-library' | |||
| id 'idea' | |||
There was a problem hiding this comment.
This is the module that has a concrete implementation of MetricsCollector, PrometheusMetricsCollector.
I'm going to publish the java client and sdk modules today. I'll uncomment this and publish this module when it's ready. There are a few TODOs.
…ent in Spring AutoConfiguration - Support both "pollingInterval" and "poll_interval" for consistency in Annotated workers config
c4lm
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Changes in this PR
Misc fixes before v4.0.0 release