Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BulkResponse parametrised #311

Merged
merged 8 commits into from
Nov 18, 2024

Conversation

shaileshpadave
Copy link
Contributor

@shaileshpadave shaileshpadave commented Nov 18, 2024

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Code changes to make BulkResponse parameterised so in case for fetching bulk objects we can return result in response
Added endpoint to search workflow details for given workflow ids.

Describe the new behavior from this PR, and why it's needed
New endpoint added on workflow-bulk resources
POST /api/workflow/bulk/search
Request Body = ["id1","id2"]

Alternatives considered

Describe alternative implementation you have considered

@shaileshpadave shaileshpadave force-pushed the BulkResponseParameterized branch from 37a11d1 to 5864006 Compare November 18, 2024 17:35
@shaileshpadave shaileshpadave force-pushed the BulkResponseParameterized branch from 5864006 to 4f6427c Compare November 18, 2024 17:49
@v1r3n v1r3n merged commit c83ce9b into conductor-oss:main Nov 18, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants