Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add name validation to task definitions and workflow definitions #315

Conversation

codehackerr
Copy link
Contributor

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

  • Add name validations for Task definition and Workflow definition

Describe the new behavior from this PR, and why it's needed
Issue #

Currently workflow and task defintions supports special character. For naming typically we need only alpha numeric, space, _ and -

Alternatives considered

Describe alternative implementation you have considered

@codehackerr codehackerr merged commit 4ae5b18 into conductor-oss:main Nov 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants