-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for consuming events from Kafka #325
Merged
v1r3n
merged 13 commits into
conductor-oss:main
from
Robban1980:feature/add_kafka_event_queue
Dec 18, 2024
Merged
Add support for consuming events from Kafka #325
v1r3n
merged 13 commits into
conductor-oss:main
from
Robban1980:feature/add_kafka_event_queue
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added logging of recived message. Added a new Test for testing JSON in the message.
added a new test for verifying payload
Fixing a handling issue with size retrieval when an EventHandler with a new Topic name is created by this queue and the AdminClient's metadata has not been updated |
…. Removed conductor.event-queues.kafka.topic property as it is not used.
v1r3n
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApply
to fix any format violations.Changes in this PR
I have implemented native support for consuming events from Kafka Topics using Conductor events handlers. This works the same as for example the SQS queue implementation but with Kafka.
Issue #127