Enhance logo visibility by supporting light and dark modes in README.md #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the README file to ensure the project logo is visible in both light and dark mode themes on platforms like GitHub. Changes Made: Added a <picture> element to conditionally display the logo based on the user's prefers-color-scheme setting. Light mode: Displays the dark logo version (default). Dark mode: Displays the light logo version (optimized for dark backgrounds). Why this change? Previously, the logo was not visible when viewed in dark mode, potentially affecting readability and branding consistency. This update ensures a seamless viewing experience for all users, regardless of their preferred theme.
v1r3n
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
NOTE: Please remember to run
./gradlew spotlessApplyto fix any format violations.Changes in this PR
This PR updates the README file to ensure the project logo is visible in both light and dark mode themes.
Added a
<picture>element to conditionally display the logo based on the user's prefers-color-scheme setting.Why this change?
Previously, the logo was not visible in dark mode, potentially affecting readability and branding consistency. This update ensures a seamless viewing experience for all users, regardless of their preferred theme.