Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Persistence/IndexDAO config #359

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

jmigueprieto
Copy link
Contributor

@jmigueprieto jmigueprieto commented Jan 8, 2025

Pull Request type

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • WHOSUSING.md
  • Other (please describe):

Changes in this PR

  • Include back conductor-es7-persistence to fix issues with existing configs which are using es7 (like docker/docker-compose.yaml).
  • Fix docker docker/docker-compose-redis-os.yaml

NOTES

This is the cause of this error when running docker compose -f docker/docker-compose.yaml up

conductor-server           | ***************************
conductor-server           | APPLICATION FAILED TO START
conductor-server           | ***************************
conductor-server           | 
conductor-server           | Description:
conductor-server           | 
conductor-server           | Parameter 2 of constructor in com.netflix.conductor.core.dal.ExecutionDAOFacade required a bean of type 'com.netflix.conductor.dao.IndexDAO' that could not be found.
conductor-server           | 
conductor-server           | 
conductor-server           | Action:
conductor-server           | 
conductor-server           | Consider defining a bean of type 'com.netflix.conductor.dao.IndexDAO' in your configuration.
conductor-server           | 

indexing is enabled with es7 config but since was removed no IndexDAO implementation is loaded in the context.

…nfigs which are using es7 (like our docker/docker-compose.yaml)
@jmigueprieto jmigueprieto self-assigned this Jan 8, 2025
@jmigueprieto jmigueprieto marked this pull request as ready for review January 8, 2025 17:04
@jmigueprieto jmigueprieto changed the title (WIP) Fix Persistence/IndexDAO config Fix Persistence/IndexDAO config Jan 8, 2025
volumes:
- esdata-conductor:/usr/share/opensearch/data
- osdata-conductor:/usr/share/opensearch/data
Copy link
Contributor Author

@jmigueprieto jmigueprieto Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a different volume to avoid conflicts with ES data. This was recently added. If anyone was using it, they can copy the data to this volume.

@@ -55,8 +55,9 @@ services:
- node.name=conductor-opensearch # Name the node that will run in this container
- discovery.seed_hosts=conductor-opensearch # Nodes to look for when discovering the cluster
- cluster.initial_cluster_manager_nodes=conductor-opensearch # Nodes eligible to serve as cluster manager
- OPENSEARCH_INITIAL_ADMIN_PASSWORD=P4zzW)rd>>123_
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this issue on docker compose up

conductor-opensearch-1  | Detected OpenSearch Version: 2.18.0
conductor-opensearch-1  | Detected OpenSearch Security Version: 2.18.0.0
conductor-opensearch-1  | No custom admin password found. Please provide a password via the environment variable OPENSEARCH_INITIAL_ADMIN_PASSWORD.
conductor-opensearch-1 exited with code 1
Gracefully stopping... (press Ctrl+C again to force)
dependency failed to start: container docker-conductor-opensearch-1 exited (1)

@jmigueprieto jmigueprieto merged commit 2a985b8 into main Jan 8, 2025
8 checks passed
@jmigueprieto jmigueprieto deleted the fix/persistence-index-config branch January 8, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants