Fix issue: Return 404 instead of 2xx codes for methods handling non-existent tasks#38

[vgopari]

Pull Request type

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes
• WHOSUSING.md
• Other (please describe):

NOTE: Please remember to run ./gradlew spotlessApply to fix any format violations.

Changes in this PR

Describe the new behavior from this PR, and why it's needed

Issue #

Alternatives considered

Describe alternative implementation you have considered

[JCHacking]

Note that changing /poll and /poll/batch can break clients (since the expected codes were 200 with content if I get homework, and 204 without content if there was none).

If you also want those methods to give 404, this change should be labeled as BREAKING CHANGE.

[vgopari]

@JCHacking, are you suggesting that we undo the code changes for /poll and /poll/batch to maintain the current behavior?

[JCHacking]

@JCHacking, are you suggesting that we undo the code changes for /poll and /poll/batch to maintain the current behavior?

No, I think it is more correct that if it fails to get a task it returns 404.

But if you make this change you may have to change the client package as well and the SDKs in other languages.

[dcore94]

I don't think that for poll it is more correct to return 404. This could be correct if task definition is not known because in that case it would actually reflect a possible error condition. 204 means operation has no errors but returns no content which is much more correct and it would not break anything.

[JCHacking]

I don't think that for poll it is more correct to return 404. This could be correct if task definition is not known because in that case it would actually reflect a possible error condition. 204 means operation has no errors but returns no content which is much more correct and it would not break anything.

You right

[vgopari]

I will revert the code to make the poll APIs return 204.

[vgopari]

Changed the status of /poll to 204 No Content, incase of non-existent tasks.