Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump csv-rs for openssl 3 support #785

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Bump csv-rs for openssl 3 support #785

merged 1 commit into from
Nov 7, 2024

Conversation

EmmEff
Copy link
Contributor

@EmmEff EmmEff commented Nov 5, 2024

Support building with openssl 3

@EmmEff
fix: bump csv-rs to support openssl 3
647c7fe 
As per commit
openanolis/csv-rs@3045440,
this implements support for OpenSSL 3

Signed-off-by: Mike Frisch <[email protected]>
@EmmEff EmmEff requested a review from a team as a code owner November 5, 2024 21:55
@Xynnn007
Copy link
Member

Xynnn007 commented Nov 6, 2024

Thanks for this! @EmmEff let's see if the CI is happy

mythi
mythi suggested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@mythi mythi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to request a bump to hyper-tls (see #614) as part of this (manual) PR on dependencies.

fitzthum
fitzthum approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@fitzthum fitzthum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are probably a few things we can bump as a result either in this PR or later. We should do this in Trustee too.

@fitzthum
Copy link
Member

fitzthum commented Nov 7, 2024

I'd like to request a bump to hyper-tls (see #614) as part of this (manual) PR on dependencies.

@mythi Let's make a follow-up for this.

@fitzthum fitzthum merged commit eb35c47 into confidential-containers:main Nov 7, 2024
15 checks passed
@EmmEff EmmEff deleted the bump-csv-rs branch November 7, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythi mythi mythi requested changes

@fitzthum fitzthum fitzthum approved these changes

@Xynnn007 Xynnn007 Xynnn007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EmmEff @Xynnn007 @fitzthum @mythi