Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a query string flag override data source #63

Merged
merged 7 commits into from
Nov 8, 2024

Conversation

adams85
Copy link
Contributor

@adams85 adams85 commented Oct 31, 2024

Describe the purpose of your pull request

Based on a user request, adds a flag override data source that use the browser URL's query string as its source.

Note that this is meant to be an experimental feature, which, if works out, will probably be included in all the SDKs running in the browser.

Related issues (only if applicable)

https://trello.com/c/5zOq7X4K

Requirement checklist (only if applicable)

  • I have covered the applied changes with automated tests.
  • I have executed the full automated test set against my changes.
  • I have validated my changes against all supported platform versions.
  • I have read and accepted the contribution agreement.

@adams85 adams85 requested a review from a team as a code owner October 31, 2024 20:14
@adams85 adams85 changed the title Implement a flag override query string data source Implement a query string flag override data source Oct 31, 2024
@adams85 adams85 force-pushed the feature/query-string-flag-override branch 3 times, most recently from b47b4b1 to cdd6f39 Compare October 31, 2024 23:08
@adams85 adams85 force-pushed the feature/query-string-flag-override branch 2 times, most recently from 5dbf587 to d2de60e Compare November 4, 2024 11:06
@adams85
Copy link
Contributor Author

adams85 commented Nov 4, 2024

I'd like a text review for this new documentation text: https://github.com/configcat/react-sdk/pull/63/files#diff-a2a171449d862fe29692ce031981047d7ab755ae7f84c707aef80701b3ea0c80R13-R25

And a UX review for

  • the naming of the new public APIs (createFlagOverridesFromQueryParams and IQueryStringProvider),

  • the parameter name format

    • default prefix: cc-,
    • "force value to be interpreted as string" suffix: ;str

    Example: &cc-myFeatureFlag;str=true

@adams85 adams85 force-pushed the feature/query-string-flag-override branch from c7c132b to 4725afc Compare November 4, 2024 11:46
Copy link

github-actions bot commented Nov 7, 2024

Head's up @configcat/ux-qa-team - someone needs a UX review!

Copy link

github-actions bot commented Nov 7, 2024

Head's up @configcat/text-reviewers - someone needs a text review!

Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
20.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@adams85 adams85 merged commit 8f8cc52 into main Nov 8, 2024
3 of 4 checks passed
@adams85 adams85 deleted the feature/query-string-flag-override branch November 8, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants