Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about deadlock with partitioner #1814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove note about deadlock with partitioner #1814

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions src/confluent_kafka/src/confluent_kafka.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@
/**
* @brief KNOWN ISSUES
*
* - Partitioners will cause a dead-lock with librdkafka, because:
* GIL + topic lock in topic_new is different lock order than
* topic lock in msg_partitioner + GIL.
* This needs to be sorted out in librdkafka, preferably making the
* partitioner run without any locks taken.
* Until this is fixed the partitioner is ignored and librdkafka's
* default will be used.
* - KafkaError type .tp_doc allocation is lost on exit.
*
*/
Expand Down