-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set consumer setting max.poll.interval.ms to rest proxy setting of co… #515
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -216,6 +216,12 @@ public String createConsumer(String group, ConsumerInstanceConfig instanceConfig | |
// and should not be propagated to the consumer | ||
props.setProperty("request.timeout.ms", "30000"); | ||
|
||
// If the consumer.timeout.ms value is set higher than the default value | ||
// for max.poll.interval.ms then it is possible the consumer will be | ||
// considered failed by the brokers while it has yet to hit the timeout | ||
// for the rest proxy. | ||
props.setProperty("max.poll.interval.ms", props.getProperty("consumer.timeout.ms", "")); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The consumer should not be considered failed by the brokers if it violates the In the case of the v2 consumer, There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Additionally, |
||
|
||
props.setProperty( | ||
"schema.registry.url", | ||
config.getString(KafkaRestConfig.SCHEMA_REGISTRY_URL_CONFIG) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The old consumer did not have the
max.poll.interval.ms
config at all - this line shouldn't have any effect