MINOR: remove ZK from code base #529
Conversation
This comment has been minimized.
This comment has been minimized.
| @@ -241,6 +238,12 @@ | |||
| <classifier>test</classifier> | |||
| <scope>test</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.apache.kafka</groupId> | |||
| <artifactId>kafka-test-common</artifactId> | |||
There was a problem hiding this comment.
To pull in KafkaClusterTestKit.
| <groupId>jakarta.xml.bind</groupId> | ||
| <artifactId>jakarta.xml.bind-api</artifactId> | ||
| <version>4.0.1</version> | ||
| </dependency> |
There was a problem hiding this comment.
W/o this, I got some ClassNotFoundException error -- just Googled for the error and found to add this... 🤷
| producer.send(new ProducerRecord<>(WikipediaFeedAvroExample.WIKIPEDIA_FEED, | ||
| new WikiFeed("john", true, "first post"))); | ||
| producer.flush(); | ||
| try (final KafkaProducer<String, WikiFeed> producer = new KafkaProducer<>(props)) { |
There was a problem hiding this comment.
Side cleanup to close the producer properly.
| final Map<String, String> effectiveBrokerConfig = effectiveBrokerConfigFrom(brokerConfig); | ||
| log.debug( | ||
| "Starting a Kafka instance on port {} ...", | ||
| effectiveBrokerConfig.get(SocketServerConfigs.LISTENERS_CONFIG) |
There was a problem hiding this comment.
Given that we don't configure this explicitly any longer, I am not 100% if this is still right?
| effectiveConfig.putAll(brokerConfig); | ||
| effectiveConfig.put(ZkConfigs.ZK_CONNECT_CONFIG, zookeeper.connectString()); | ||
| effectiveConfig.put(ZkConfigs.ZK_SESSION_TIMEOUT_MS_CONFIG, 30 * 1000); | ||
| effectiveConfig.put(SocketServerConfigs.LISTENERS_CONFIG, String.format("PLAINTEXT://127.0.0.1:%s", DEFAULT_BROKER_PORT)); |
There was a problem hiding this comment.
Needed to remove this -- otherwise, I got some config errors about other missing config... not sure why this was set to begin with? Did not want to go down the rabbit whole figuring out all other required/dependent configs to keep it (also not sure why it did work with the old setup, but not the new one... 🤷)
| } catch (final Exception fatal) { | ||
| throw new RuntimeException(fatal); | ||
| if (schemaRegistry != null) { | ||
| schemaRegistry.stop(); | ||
| } | ||
| if (broker != null) { | ||
| broker.stop(); |
There was a problem hiding this comment.
this throws now, so changed the try-catch to also handle it.
| @@ -267,16 +253,14 @@ private TopicsDeletedCondition(final String... topics) { | |||
|
|
|||
| @Override | |||
| public boolean conditionMet() { | |||
| //TODO once KAFKA-6098 is fixed use AdminClient to verify topics have been deleted | |||
There was a problem hiding this comment.
This is not fixed yet... but was simplest to just use Admin client now...
| private Properties effectiveConfigFrom(final Properties initialConfig) { | ||
| final Properties effectiveConfig = new Properties(); | ||
| effectiveConfig.put(ServerConfigs.BROKER_ID_CONFIG, 0); | ||
| effectiveConfig.put(SocketServerConfigs.LISTENERS_CONFIG, "PLAINTEXT://127.0.0.1:9092"); |
There was a problem hiding this comment.
As above. Removed this one.
Analysis Details2 Issues
Coverage and Duplications
Project ID: kafka-streams-examples |
.semaphore/semaphore.yml
Outdated
| @@ -24,7 +24,7 @@ global_job_config: | |||
| prologue: | |||
| commands: | |||
| - checkout | |||
| - sem-version java 11 | |||
| - sem-version java 17 | |||
airlock-confluentinc
bot
force-pushed
the
remove-zk
branch
from
2338aa8 to
241652b
Compare
airlock-confluentinc
bot
force-pushed
the
remove-zk
branch
from
8c2b34b to
d79f036
Compare
No description provided.