feature: Add min batch size support #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to lack of updating last check time when no offsets were able to be committed.
squash: turn down size of high volume test and remove Isolated from mult instance reblaance
squash-fix: Add missing resource lock to static state accessing test
Dont share collections in test and synchronise collection access.
…ulation Elapsed duration was truncating ms, cause frequency check to always return ok - causing the spin lock on commits
Running tests in parallel on jenkins puts a lot more load on it - ease up on requirements. Longer delay for chance to rebalance. Assert no concurrent exception instead of catching.
Experiencing some failures in Jenkins environment.
Add support for managed executor service
`find ./ -type f -print0 | xargs -0 dos2unix --`
Fixes confluentinc#60 - upgrade AK to 2.7.0. Adds 2.7.0 as a stable build.
This messes with the shutdown process of the Producer, i.e. committing final transactions, offsets etc.
…itions are revoked (confluentinc#548) * Fix deadlock on partitions revoked * Add unit test for rebalance deadlock on EoS * Update changelog and readme * merge with master changes * Fix misplaced comment
…nc#556) Bumps `mockito.version` from 4.9.0 to 5.1.1. Updates `mockito-core` from 4.9.0 to 5.1.1 - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.9.0...v5.1.1) Updates `mockito-junit-jupiter` from 4.9.0 to 5.1.1 - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](mockito/mockito@v4.9.0...v5.1.1) --- updated-dependencies: - dependency-name: org.mockito:mockito-core dependency-type: direct:development update-type: version-update:semver-major - dependency-name: org.mockito:mockito-junit-jupiter dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: John Byrne <[email protected]>
Bumps `vertx.version` from 4.3.6 to 4.4.1. Updates `vertx-web-client` from 4.3.6 to 4.4.1 Updates `vertx-junit5` from 4.3.6 to 4.4.1 --- updated-dependencies: - dependency-name: io.vertx:vertx-web-client dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: io.vertx:vertx-junit5 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…entinc#555) Bumps [versions-maven-plugin](https://github.com/mojohaus/versions) from 2.14.1 to 2.15.0. - [Release notes](https://github.com/mojohaus/versions/releases) - [Changelog](https://github.com/mojohaus/versions/blob/master/ReleaseNotes.md) - [Commits](mojohaus/versions@2.14.1...2.15.0) --- updated-dependencies: - dependency-name: org.codehaus.mojo:versions-maven-plugin dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…c#528) Bumps [threeten-extra](https://github.com/ThreeTen/threeten-extra) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/ThreeTen/threeten-extra/releases) - [Commits](ThreeTen/threeten-extra@v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: org.threeten:threeten-extra dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…nfluentinc#544) * Avoid expensive calculation of properties for debug / trace logging when debug / trace logging is not enabled. --------- Co-authored-by: Lenne Hendrickx <[email protected]>
rkolesnev
suggested changes
May 26, 2023
There was a problem hiding this comment.
In general logical flow looks fine to me.
I would really like to see more tests and integration tests for it though - with transactions, different ordering modes (Unordered / Key /Partition) and 'normal' non-reactor usage mode of PC - it has a potential to introduce edge case issues that additional tests could shake out.
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/ParallelConsumerOptions.java
Outdated
Show resolved
Hide resolved
PR Summary
|
…entinc#580) Bumps [maven-release-plugin](https://github.com/apache/maven-release) from 3.0.0-M7 to 3.0.1. - [Release notes](https://github.com/apache/maven-release/releases) - [Commits](apache/maven-release@maven-release-3.0.0-M7...maven-release-3.0.1) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-release-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Ehud-Lev-Forter
force-pushed
the
ehud-lev-add-min-batch-size
branch
from
77de211 to
4b17c0d
Compare
…nkins (confluentinc#583) * update dependencies * add maven wrapper * Update jenkinsfile to use mvnw * Add to changelog
* update dependencies
* add instance id into thread name * Add instance id to thread name if possible --------- Co-authored-by: lixy <[email protected]> Co-authored-by: Edward Vaisman <[email protected]>
eddyv
reviewed
Jun 20, 2023
parallel-consumer-core/src/main/java/io/confluent/parallelconsumer/ParallelConsumerOptions.java
Outdated
Show resolved
Hide resolved
…umer/ParallelConsumerOptions.java Co-authored-by: Edward Vaisman <[email protected]>
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add min batch size support
We would like to support minimum batch size. Since we might have a time with no traffic and we don't want to wait forever for the events that are not satisfy minimum batch, we will also add
minBatchTimeoutInMillis, if we passed this timeout, code will be as today.see issue
Checklist