V1: Use sigterm instead of interrupt to stop a process #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
Nov 20, 2023
…p child process; improve -v output
jhump
force-pushed
the
jh/use-sigterm
branch
from
8dde010 to
35da051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@srikrsna-buf, pointed out an issue that trying to use
go run ...as the server under test caused the test runner to hang. It turns out that this is becausego run ...ignores SIGINT, which is how the runner was previously trying to stop a test process.Now it uses SIGTERM. Also, it now cancels the process's context.
This also improves the output when using
-v. Previously, it would log information about all server instances up-front. Now it logs as it goes, so it's possible to see its progress (if it makes any). This also tweaks some of the messages, so it also shows when it's using the normal reference client or server vs. the gRPC version.