V1: (Last?) tweak to the protos #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smaye81
approved these changes
Nov 20, 2023
jhump
force-pushed
the
jh/proto-tweak
branch
from
f9af081 to
e322b2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are hopefully final updates to the protos before pushing to a new BSR module and merging v1 to main.
These will be used in the changes to the reference client and server to use raw requests and responses (preview in #682). They include a backwards-incompatible change (making the length unsigned), so I wanted to get this in before pushing to the BSR. After we push to the BSR, we can enable
buf breakingchecks to keep us from making incompatible changes going forward.