Slight re-organization: make test suite YAML files easier to find and move grpcwebclient into "testing" folder #775
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had hoped to move the test suite YAML files up to a top-level
testsuites
folder. But thego:embed
stuff doesn't allow that: you cannot use ".." in the path, which means we'd also have to drop the.go
file into the top-level folder, which would result in an exported/non-internal Go package, which we don't want.So instead, this adds a sym-link named
testsuites
that links to the folder where the YAML files are. This also moves the YAML files into adata
sub-directory so when you look at thetestsuites
top-level orcd
into it, you just get the YAML files (and not the accompanying Go file).This also moves
grpcwebclient
into a newtesting
folder, along with the contents oftestdata
, just so it's not so prominent in the root repo, considering it is only used to test the reference implementations.Last little thing, while I was in the
Makefile
: I removed the "ignore" items for thelicense-header
tool. I did this for consistency because I don't see such "ignore" flags in other repos. Also, it didn't have any impact on the generated output so removing it was harmless.