Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slight re-organization: make test suite YAML files easier to find and move grpcwebclient into "testing" folder #775

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

jhump
Copy link
Member

@jhump jhump commented Feb 7, 2024

I had hoped to move the test suite YAML files up to a top-level testsuites folder. But the go:embed stuff doesn't allow that: you cannot use ".." in the path, which means we'd also have to drop the .go file into the top-level folder, which would result in an exported/non-internal Go package, which we don't want.

So instead, this adds a sym-link named testsuites that links to the folder where the YAML files are. This also moves the YAML files into a data sub-directory so when you look at the testsuites top-level or cd into it, you just get the YAML files (and not the accompanying Go file).

This also moves grpcwebclient into a new testing folder, along with the contents of testdata, just so it's not so prominent in the root repo, considering it is only used to test the reference implementations.

Last little thing, while I was in the Makefile: I removed the "ignore" items for the license-header tool. I did this for consistency because I don't see such "ignore" flags in other repos. Also, it didn't have any impact on the generated output so removing it was harmless.

…ml files; rename 'testdata' to 'testing' and move grpcwebclient into it
@jhump jhump enabled auto-merge (squash) February 8, 2024 16:30
@jhump jhump merged commit 0b9e841 into main Feb 8, 2024
4 checks passed
@jhump jhump deleted the jh/reorg branch February 8, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants