Remove connect-go reference implementation workaround for HTTP/1.x streams #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i support This PR removes the workarounds to support Bidi streams over HTTP1 transports. Support is now added upstream in the connect-go library. Signed-off-by: Edward McFarlane <[email protected]>
emcfarlane
force-pushed
the
ed/connectGohttp1BidiSupport
branch
from
54448d2
to
731f3d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the workarounds to support bidi streams over HTTP/1.x transports. Support is now added upstream in the connect-go library in connectrpc/connect-go#796 .
Test will fail until connectrpc/connect-go#796 is merged. Will update when pulled in.
Closing until upstream is merged.