Skip to content

Commit

Permalink
Only run conformance tests for @connectrpc/connect-web on Node.js wit…
Browse files Browse the repository at this point in the history
…h the task "conformance"

Signed-off-by: Timo Stamm <[email protected]>
  • Loading branch information
timostamm committed Aug 30, 2024
1 parent d725a6c commit 6a3b001
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,10 @@ and `npm` in the version specified in `package.json`):
npm ci
```

Make sure that the tests and the linters pass:
Make sure that the tests, linters, and other checks pass:

```bash
npx turbo run test lint
npm run all
```

We're using `turborepo` to run tasks. If you haven't used it yet, take a look at
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"packages/connect-cloudflare"
],
"scripts": {
"all": "turbo run build format test conformance bundle-size lint attw license-header",
"all": "turbo run --ui tui build format test conformance bundle-size lint attw license-header",
"clean": "git clean -Xdf",
"setversion": "node scripts/set-workspace-version.js",
"postsetversion": "npm run all",
Expand Down
5 changes: 1 addition & 4 deletions packages/connect-web/turbo.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,7 @@
"dependsOn": ["generate", "^build"]
},
"conformance": {
"dependsOn": [
"conformance:node:promise",
"conformance:node:callback"
]
"dependsOn": ["conformance:node:promise", "conformance:node:callback"]
},
"conformance:safari": {
"cache": false,
Expand Down

0 comments on commit 6a3b001

Please sign in to comment.