Support Express v5 in @connectrpc/connect-fastify #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
timostamm
commented
Nov 4, 2024
Comment on lines
+74
to
+75
| Note that Express does not support the Node.js `http2` module. You can serve the | ||
| Connect protocol and gRPC-Web with Express, but not gRPC. |
There was a problem hiding this comment.
V2 gRPC clients do not support H1: #1279
| @@ -97,8 +97,10 @@ function main() { | |||
| switch (req.httpVersion) { | |||
| case HTTPVersion.HTTP_VERSION_1: | |||
| server = req.useTls | |||
| ? https.createServer(serverOptions, app) | |||
| : http.createServer(app); | |||
| ? // eslint-disable-next-line @typescript-eslint/no-misused-promises -- typing issue in express | |||
There was a problem hiding this comment.
Not sure why eslint considers this to be a promise misuse. Either way, it isn't something we can fix, since it's an issue with Express' typings.
| "tsx": "^4.19.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "express": "^4.18.2 || ^5.0.1", |
There was a problem hiding this comment.
Not sure why we didn't have a peer dependency for express before.
srikrsna-buf
approved these changes
Nov 4, 2024
timostamm
deleted the
tstamm/v2/Support-Express-v5-in-@connectrpc/connect-fastify
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relaxes the peer dependency constraint on express to include ^5.0.1.
Closes #1293.