Fix quote style in migration CLI #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-sachs
reviewed
Aug 17, 2023
Merged
paul-sachs
approved these changes
Aug 17, 2023
paul-sachs
added a commit
that referenced
this pull request
Aug 18, 2023
* wip * Basic operations working * Remove unused dep an move some files * Remove test files from includes Add comment to fix lint * Fix lint * Reorg * Some review comments - Added support to detect quote style * Removed tsup and reorganized bin files * Updated to run jscodeshift directly * Remove jest dependency * Fix up test fixtures * Added rename and remove unused cli argument * Update readme * Update logic to detect failed install * Remove dynamic RegExp * Use explicit check * Add connect-migrate to makefile * Add clean stage to match protoc * Fix formatting * Update packages/connect-migrate/tsconfig.json Co-authored-by: Timo Stamm <[email protected]> * Update packages/connect-migrate/package.json Co-authored-by: Timo Stamm <[email protected]> * Update packages/connect-migrate/package.json Co-authored-by: Timo Stamm <[email protected]> * Update packages/connect-migrate/src/transforms/modify-imports.spec.ts Co-authored-by: Timo Stamm <[email protected]> * Add recursive, ignore-pattern, and no-install flags * Fix quote style in migration CLI (#774) * Use different parsers for different file endings Add comment to readme to allow more customization. * updated lock file * Fix lint * Improve DX with migration CLI (#776) --------- Co-authored-by: Timo Stamm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches tests to the pattern suggested in #769 (comment) and updates the description to be in sync between readme, CLI usage, package description.