Port to v2 #389
Port to v2 #389
Conversation
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
|
Hey @srikrsna-buf , any update on this? Would love to see it merged! 😄 Thanks |
|
@itsjoeoui, we want to release connect-es, connect-query-es, and connect-playwright-es with support for v2, and update the documentation where necessary. We plan to release it at the same time to make it easier to upgrade. That's why this PR isn't active right now, but we are actively working on the release 🙂 |
Awesome! Thanks for the update 👍 |
| return create( | ||
| methodSig.output, | ||
| ( | ||
| updater as (prev?: MessageShape<O>) => MessageInitShape<O> | undefined |
There was a problem hiding this comment.
Weird cast, is this even needed?
There was a problem hiding this comment.
Yes.
Unsafe argument of type
anyassigned to a parameter of typeMessageInitShape<DescMessage & O> | undefined@typescript-eslint/no-unsafe-argument
There was a problem hiding this comment.
Ah weird. My IDE didn't have any problems. Good to know.
Signed-off-by: Sri Krishna <[email protected]>
Signed-off-by: Sri Krishna <[email protected]>
Port to v2 of connect and protobuf. User code doesn't change unless using some internal types and functions.