Add more Sendable conformances to resolve warnings (#309)

Resolves warnings that appear when compiling with Xcode 16 / Swift 6. These warnings can be seen in https://github.com/connectrpc/connect-swift/actions/runs/11248587333. Signed-off-by: Michael Rebello <[email protected]>
connectrpc · Oct 9, 2024 · 7bbb10b · 7bbb10b
1 parent 5b7ea4d
commit 7bbb10b
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 6 deletions.
diff --git a/Libraries/Connect/Internal/Streaming/ClientOnlyAsyncStream.swift b/Libraries/Connect/Internal/Streaming/ClientOnlyAsyncStream.swift
@@ -23,7 +23,7 @@ import Foundation
 @available(iOS 13, *)
 final class ClientOnlyAsyncStream<
     Input: ProtobufMessage, Output: ProtobufMessage
->: BidirectionalAsyncStream<Input, Output> {
+>: BidirectionalAsyncStream<Input, Output>, @unchecked Sendable {
     private let receivedResults = Locked([StreamResult<Output>]())
 
     override func handleResultFromServer(_ result: StreamResult<Output>) {

diff --git a/...es/Connect/Public/Interfaces/Streaming/AsyncAwait/BidirectionalAsyncStreamInterface.swift b/...es/Connect/Public/Interfaces/Streaming/AsyncAwait/BidirectionalAsyncStreamInterface.swift
@@ -16,7 +16,7 @@ import SwiftProtobuf
 
 /// Represents a bidirectional stream that can be interacted with using async/await.
 @available(iOS 13, *)
-public protocol BidirectionalAsyncStreamInterface<Input, Output> {
+public protocol BidirectionalAsyncStreamInterface<Input, Output>: Sendable {
     /// The input (request) message type.
     associatedtype Input: ProtobufMessage
 

diff --git a/...aries/Connect/Public/Interfaces/Streaming/AsyncAwait/ClientOnlyAsyncStreamInterface.swift b/...aries/Connect/Public/Interfaces/Streaming/AsyncAwait/ClientOnlyAsyncStreamInterface.swift
@@ -17,7 +17,7 @@ import SwiftProtobuf
 /// Represents a client-only stream (a stream where the client streams data to the server and
 /// eventually receives a response) that can be interacted with using async/await.
 @available(iOS 13, *)
-public protocol ClientOnlyAsyncStreamInterface<Input, Output> {
+public protocol ClientOnlyAsyncStreamInterface<Input, Output>: Sendable {
     /// The input (request) message type.
     associatedtype Input: ProtobufMessage
 

diff --git a/...aries/Connect/Public/Interfaces/Streaming/AsyncAwait/ServerOnlyAsyncStreamInterface.swift b/...aries/Connect/Public/Interfaces/Streaming/AsyncAwait/ServerOnlyAsyncStreamInterface.swift
@@ -17,7 +17,7 @@ import SwiftProtobuf
 /// Represents a server-only stream (a stream where the server streams data to the client after
 /// receiving an initial request) that can be interacted with using async/await.
 @available(iOS 13, *)
-public protocol ServerOnlyAsyncStreamInterface<Input, Output> {
+public protocol ServerOnlyAsyncStreamInterface<Input, Output>: Sendable {
     /// The input (request) message type.
     associatedtype Input: ProtobufMessage
 

diff --git a/Libraries/ConnectNIO/Public/NIOHTTPClient.swift b/Libraries/ConnectNIO/Public/NIOHTTPClient.swift
@@ -15,7 +15,7 @@
 import Connect
 import Foundation
 import NIOConcurrencyHelpers
-import NIOCore
+@preconcurrency import NIOCore // TODO: Convert to normal import once `ChannelHandler` is `Sendable`
 import NIOHTTP1
 import NIOHTTP2
 import NIOPosix

diff --git a/Tests/ConformanceClient/Sources/ConformanceInvoker.swift b/Tests/ConformanceClient/Sources/ConformanceInvoker.swift
@@ -19,7 +19,7 @@ import SwiftProtobuf
 
 /// Class responsible for running a specific conformance test case against a service.
 @available(macOS 10.15.4, iOS 13.4, watchOS 6.2, tvOS 13.4, *)
-final class ConformanceInvoker {
+final class ConformanceInvoker: Sendable {
     private let client: ConformanceClient
     private let context: ConformanceRequest