Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crosstest reference text #163

Merged
merged 5 commits into from
Sep 8, 2023
Merged

Update crosstest reference text #163

merged 5 commits into from
Sep 8, 2023

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Sep 8, 2023

This updates references to the crosstest repo to use conformance instead.

Note that the Docker image used for crosstests still uses an old bufbuild image. This is because the test proto packages have changed in the new repo and switching to use one of the new images would cause all existing code to break. This will be fixed in a follow-up PR.

@smaye81 smaye81 marked this pull request as ready for review September 8, 2023 04:12
@smaye81
Copy link
Member Author

smaye81 commented Sep 8, 2023

@rebello95 I closed #158 and am going to split it up into two separate PRs. This one can be landed first, which updates most of the text and references to use conformance but does not use the new images and new proto packages. Then, I can look into a follow-up PR as to why the new images won't pass tests.

Copy link
Collaborator

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md needs to be updated

@smaye81 smaye81 merged commit ecc1104 into main Sep 8, 2023
8 checks passed
@smaye81 smaye81 deleted the sayers/crosstest_text branch September 8, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants