Prepare for OSS #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare for eventual open-source release by updating the copyright holder to match the rest of the Connect projects.
Align our recommendations here with https://connectrpc.com/docs/cors, and trim the list of headers down to the ones actually required. Along the way, clarify the documentation a bit and correct places where we were confusing the preflight and actual responses.
Anticipating release as part of the Connect project, change the import path to `connectrpc.com/cors`, add the usual badges to the README, and re-word the README a bit for clarity.
emcfarlane
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares this module for an OSS release by aligning it with the rest of
the Connect project (including changing import paths and anticipating a change
in Github organization) and correcting some small errors.
It's easiest to review commit-by-commit. The first few commits are just OSS
housekeeping:
The last two commits are more substantive, and bring this package into
alignment with the recommendations in the public
docs: