Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project skeleton #3

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Add project skeleton #3

merged 3 commits into from
Aug 24, 2023

Conversation

elliotmjackson
Copy link
Contributor

@elliotmjackson elliotmjackson commented Aug 24, 2023 •
edited by akshayjshah
Loading

Add a project skeleton (Makefiles, lint config, etc.) for use later on.

akshayjshah
akshayjshah requested changes Aug 24, 2023
View reviewed changes
Copy link
Member

@akshayjshah akshayjshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small comments inline; let's also get CI passing by adding a validate.go file with nothing but a package declaration.

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/emergency-review-bypass.yaml Outdated Show resolved Hide resolved
.github/workflows/notify-approval-bypass.yaml Outdated Show resolved Hide resolved
@elliotmjackson elliotmjackson merged commit f456db7 into main Aug 24, 2023
4 checks passed
@elliotmjackson elliotmjackson deleted the ejackson/add-skeleton branch August 24, 2023 20:56
elliotmjackson added a commit that referenced this pull request Aug 29, 2023
@elliotmjackson
Add project skeleton (#3)
5b79d93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshayjshah akshayjshah akshayjshah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliotmjackson @akshayjshah