-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): harden transaction inclusion logic to account for fee market #1239
Open
raulk
wants to merge
10
commits into
main
Choose a base branch
from
raulk/fix/reject-below-base-fee
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gas fee cap below minimal base fee. - gas limit above maximum block gas limit.
raulk
force-pushed
the
raulk/fix/reject-below-base-fee
branch
from
January 2, 2025 16:35
05c6790
to
cd07cec
Compare
raulk
changed the title
fix: reject block if it includes messages below the base fee.
fix(node): reject block if it includes messages below the base fee.
Jan 2, 2025
cryptoAtwill
reviewed
Jan 3, 2025
raulk
changed the title
fix(node): reject block if it includes messages below the base fee.
fix(node): harden transaction inclusion logic to account for fee market
Jan 3, 2025
cryptoAtwill
approved these changes
Jan 3, 2025
LePremierHomme
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves correctness of tx inclusion logic on two fronts.
Some type shenanigans via downcasts were necessary to deal with #1241. Tested by extending a materializer test.
Exclude non-includable messages at proposal time.
Randomize message selection to prevent attackers from predicting or controlling message inclusion.
This change is