Skip to content

Commit

Permalink
basehub: allow shared-volume-reporter to be disabled
Browse files Browse the repository at this point in the history
  • Loading branch information
consideRatio committed Apr 29, 2024
1 parent 94e356b commit 569be29
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 0 deletions.
8 changes: 8 additions & 0 deletions helm-charts/basehub/templates/home-space-reporter.yaml
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
{{- if .Values.nfs.enabled }}
{{- if .Values.nfs.volumeReporter.enabled }}
# To provide data for the jupyterhub/grafana-dashboards dashboard about free
# space in the shared volume, which contains users home folders etc, we deploy
# prometheus node-exporter to collect this data for prometheus server to scrape.
#
# This prometheus metrics exporter will when used against a shared EFS storage
# (AWS NFS service) report an extreme amount of available disk space, making the
# available space remaining 100%. This makes the jupyterhub/grafana-dashboards
# graph reporting remaining available disk space in % quite pointless. Due to
# that, it can make sense to disable this if EFS is used to provide storage as
# it becomes another pod that eats up the available pods per node.
#
# This is based on the Deployment manifest in jupyterhub/grafana-dashboards'
# readme: https://github.com/jupyterhub/grafana-dashboards#additional-collectors
#
Expand Down
8 changes: 8 additions & 0 deletions helm-charts/basehub/values.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,14 @@ properties:
properties:
enabled:
type: boolean
volumeReporter:
type: object
additionalProperties: false
required:
- enabled
properties:
enabled:
type: boolean
shareCreator:
type: object
additionalProperties: false
Expand Down
2 changes: 2 additions & 0 deletions helm-charts/basehub/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ nfs:
enabled: false
dirsizeReporter:
enabled: true
volumeReporter:
enabled: true
shareCreator:
enabled: true
tolerations: []
Expand Down

0 comments on commit 569be29

Please sign in to comment.