Update to symfony7 #70
Conversation
.github/workflows/ci.yml
Outdated
| php-version: "8.3" | ||
| dependencies: highest | ||
|
|
||
| - os: ubuntu-latest | ||
| php-version: "8.0" | ||
| dependencies: highest | ||
| php-ini-values: assert.exception=1, zend.assertions=1, opcache.enable=1, opcache.enable_cli=1, opcache.optimization_level=-1, opcache.jit_buffer_size=4096M, opcache.jit=1205 | ||
|
|
||
| - os: ubuntu-latest | ||
| php-version: "8.1" | ||
| php-version: "8.3" |
There was a problem hiding this comment.
we have two 8.3 and highest here - do we need both? is it because of the ini values?
There was a problem hiding this comment.
The tests were previously 8.0 and 8.1. As you said, there is no need to do 8.3 twice. The base test should be 8.2, so if we wanted to test all versions, we could list 8.0, 8.1 and 8.3 here. Maybe it's okay to not do all of versions and just pick some representative ones.
.github/workflows/ci.yml
Outdated
| @@ -24,7 +24,7 @@ jobs: | |||
| - name: Install PHP | |||
| uses: shivammathur/setup-php@v2 | |||
| with: | |||
| php-version: 7.4 | |||
| php-version: 8.3 | |||
There was a problem hiding this comment.
It's best to make the base test the lowest supported version PHP supported by the composer.lock file, e.g. 8.2.
.github/workflows/ci.yml
Outdated
| @@ -82,30 +85,25 @@ jobs: | |||
| - windows-latest | |||
|
|
|||
| php-version: | |||
| - "7.4" | |||
| - "8.3" | |||
.github/workflows/ci.yml
Outdated
|
|
||
| php-ini-values: | ||
| - assert.exception=1, zend.assertions=1 | ||
|
|
||
| dependencies: | ||
| - locked |
There was a problem hiding this comment.
The base test should be "locked", not "highest"
.github/workflows/ci.yml
Outdated
|
|
||
| include: | ||
| - os: ubuntu-latest | ||
| php-version: "7.4" | ||
| dependencies: lowest | ||
|
|
||
| - os: ubuntu-latest | ||
| php-version: "7.4" | ||
| php-version: "8.3" |
There was a problem hiding this comment.
Keep this "7.4" so that we can do a "highest" test on the older php version.
composer.json
Outdated
| @@ -53,7 +53,7 @@ | |||
| "optimize-autoloader": true, | |||
| "sort-packages": true, | |||
| "platform": { | |||
| "php": "7.4" | |||
| "php": "8.3" | |||
Please review the 4 matrix jobs in CI to make sure they provide good coverage.