Skip to content

Commit

Permalink
Symfony 7 (#78)
Browse files Browse the repository at this point in the history
* Update to symfony7

* Comply with parent return type

* Clean up dependencies now that we have some stable releases. Adjust php versions used in tests.

* Simplify workflows configuration changes

* Update backward-compatibility check tool version. Let's try testing PHP 8.0 and see if it fares better with the tty restriction.

* Skip tests that need tty on CI

* Let tty tests run in PHP versions < 8.2.0, since that should be Symfony 6 or less.

* Used the wrong comparison operator

* Add a comment explaining the logic (or illogic) of when I skip the tty tests.

---------

Co-authored-by: Lee Rowlands <[email protected]>
Co-authored-by: Moshe Weitzman <[email protected]>
  • Loading branch information
3 people authored Apr 5, 2024
1 parent 5e8eff5 commit 91c99b9
Show file tree
Hide file tree
Showing 6 changed files with 406 additions and 817 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- name: Install PHP
uses: shivammathur/setup-php@v2
with:
php-version: 8.0
php-version: 8.2
coverage: none

- name: Install dependencies
Expand Down Expand Up @@ -53,16 +53,16 @@ jobs:
- name: Install PHP with extensions
uses: shivammathur/setup-php@v2
with:
php-version: 7.4
php-version: 8.2
coverage: none
extensions: intl

- name: Install roave/backward-compatibility-check
run: |
mkdir -p tools
composer --working-dir=tools require roave/backward-compatibility-check:^5 --no-update
echo '{}' > tools/composer.json
composer --working-dir=tools config --no-plugins allow-plugins.ocramius/package-versions true
composer --working-dir=tools update
composer --working-dir=tools require roave/backward-compatibility-check:^7
- name: Run roave/backward-compatibility-check
run: ./tools/vendor/bin/roave-backward-compatibility-check --from=5.0.0
Expand All @@ -82,7 +82,7 @@ jobs:
- windows-latest

php-version:
- "8.0"
- "8.2"

php-ini-values:
- assert.exception=1, zend.assertions=1, opcache.enable=1, opcache.enable_cli=1, opcache.optimization_level=-1, opcache.jit_buffer_size=4096M, opcache.jit=1205
Expand All @@ -92,7 +92,7 @@ jobs:

include:
- os: ubuntu-latest
php-version: "8.1"
php-version: "8.0"
dependencies: highest
php-ini-values: assert.exception=1, zend.assertions=1, opcache.enable=1, opcache.enable_cli=1, opcache.optimization_level=-1, opcache.jit_buffer_size=4096M, opcache.jit=1205

Expand Down
8 changes: 4 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@
},
"require": {
"php": ">=8.0.14",
"consolidation/config": "^2",
"consolidation/config": "^2 || ^3",
"consolidation/site-alias": "^3 || ^4",
"symfony/process": "^6",
"symfony/console": "^5.4 || ^6"
"symfony/process": "^6 || ^7",
"symfony/console": "^5.4 || ^6 || ^7"
},
"require-dev": {
"squizlabs/php_codesniffer": "^3",
Expand All @@ -51,7 +51,7 @@
"optimize-autoloader": true,
"sort-packages": true,
"platform": {
"php": "8.0.14"
"php": "8.2.17"
},
"allow-plugins": {
"ocramius/package-versions": true
Expand Down
Loading

0 comments on commit 91c99b9

Please sign in to comment.